#666 - Concrete Minkowski sum for polygons #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
May 16, 2019
mforets
requested changes
May 16, 2019
There was a problem hiding this comment.
Thanks a lot for your first contribution!!
Looks good, but I left some comments below. Also, could you add some tests and the new function to the docs? (see extending the online documentation) -- you can add the new doc here and the new tests in test/unit_Polygon.jl.
mforets
reviewed
May 17, 2019
mforets
reviewed
May 17, 2019
mforets
approved these changes
May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #666